Fix request filtering for service stats#2678
Merged
Conversation
Instead of relying on status codes or other heuristics, have Nginx log a flag for each request forwarded, or intended to be forwarded, to a service replica. Use these flags to determine which requests to include in service stats. This reliably excludes requests that are terminated by Nginx and hence don't add load to replicas. These include HTTP to HTTPS redirects, unauthenticated requests, and requests that violate rate or body size limits.
r4victor
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on status codes or other
heuristics, have Nginx log a flag for each request
forwarded, or intended to be forwarded, to a
service replica. Use these flags to determine
which requests to include in service stats.
This reliably excludes requests that are
terminated by Nginx and hence don't add load to
replicas. These include HTTP to HTTPS redirects,
unauthenticated requests, and requests that
violate rate or body size limits.
Fixes #2662